Connect to sage intacct #43661

SzymczakJ · 2024-06-13T13:39:13Z

Details

Fixed Issues

$ #43532
PROPOSAL: N/A

Tests

On account with no preexisting connections to Sage Intacct
On workspace page go to the "More features" and enable "Accounting"
Go to the new "Accounting" menu entry and try setting up connection with Sage Intacct.
Verify that Prerequisites screen looks like this:

Verify that Enter Credentials page looks like this:
Connect to Sage Intacct // right now we can connect on Old Dot
Create another workspace and try connecting it to Sage Intacct
Verify that you pop up/modal with “Create new connection” and “Reuse existing connection” options pops up

Verify that “Create new connection” button navigates to Prerequisites
Verify that “Reuse exiting connection” navigates to “Existing connections” which lists all workspaces that are connected to Sage Intacct

Offline tests

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-06-28.at.13.44.06.mov

Android: mWeb Chrome

anotherandroid.mov

iOS: Native

ios.mov

iOS: mWeb Safari

mwebIOS1.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

SzymczakJ · 2024-06-17T13:34:38Z

Please ignore the typescript error for now as it's not really connected. I'll fix it later(I hope that it will be fixed by some other PR and I will just merge main 😃)

src/ROUTES.ts

src/libs/PolicyUtils.ts

src/pages/workspace/accounting/intacct/EnterSageIntacctCredentialsPage.tsx

war-in · 2024-06-17T14:24:36Z

src/pages/workspace/accounting/intacct/ExistingConnectionsPage.tsx

+            key: policy.id,
+            icon: policy.avatarURL ? policy.avatarURL : ReportUtils.getDefaultWorkspaceAvatar(policy.name),
+            iconType: policy.avatarURL ? CONST.ICON_TYPE_AVATAR : CONST.ICON_TYPE_WORKSPACE,
+            description: date ? `Sage Intacct - Last synced ${date}` : 'Sage Intacct',


war-in · 2024-06-18T12:28:49Z

src/languages/en.ts

+                if (!integrationToConnect) {
+                    return `Are you sure you want to disconnect ${currentIntegration || 'this integration'}?`;
+                }
+                return `Are you sure you want to disconnect ${currentIntegration || 'this integration'} to set up ${integrationToConnect}`;


we don't have an alternative for the integrationToConnect (in case it is undefined)

war-in · 2024-06-18T12:29:10Z

src/languages/es.ts

+                if (!integrationToConnect) {
+                    return `¿Estás seguro de que quieres desconectar ${currentIntegration || 'integración'}?`;
+                }
+                return `¿Estás seguro de que quieres desconectar ${currentIntegration || 'this integration'} para configurar ${integrationToConnect}`;


war-in · 2024-06-18T12:33:16Z

src/libs/actions/Policy/Member.ts

why do we need to change this file 🤔 Are there any important changes?

It's fix for typescript error that also happens on main. When this type error will be fixed on main this changes will not be present on this PR.

war-in · 2024-06-18T12:34:16Z

src/libs/actions/Policy/Policy.ts

this one seems unrelated to the PR (like the one above)

Same as above.

melvin-bot · 2024-06-18T13:21:12Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

war-in

LGTM 🔥

src/libs/PolicyUtils.ts

src/pages/workspace/accounting/intacct/EnterSageIntacctCredentialsPage.tsx

hungvu193 · 2024-06-18T14:46:02Z

src/pages/workspace/accounting/intacct/ExistingConnectionsPage.tsx

This page will be empty if there's no existing connection, I think we will need a placeholder or smth here 🤔
Or Should we disable Reuse existing connection from three dot menu?
cc @yuwenmemon

If there is no existing connection, then this page will never show up. User will be navigated directly to IntacctPrerequisitesPage

This's what I'm seeing, I still can open it from three dot menu

Screen.Recording.2024-06-19.at.09.10.09.mov

That's on me, now with new condition this ThreeDotsMenu won't open when there's no existing Sage Intacct connection

src/pages/workspace/accounting/intacct/IntacctPrerequisitesPage.tsx

src/pages/workspace/accounting/intacct/EnterSageIntacctCredentialsPage.tsx

src/pages/workspace/accounting/intacct/ExistingConnectionsPage.tsx

hungvu193 · 2024-06-28T03:15:14Z

We have conflicts here @SzymczakJ
Also can you complete the author checklist in the meantime? TIA

hungvu193 · 2024-06-28T10:02:09Z

I got a loop while going back from EnterSageIntacctCredentialsPage. That's all I got, we can go ahead after this is fixed.

Screen.Recording.2024-06-28.at.17.00.31.mov

SzymczakJ · 2024-06-28T12:59:44Z

Fixed all comments and completed author checklist, I think this is ready for merge.

hungvu193 · 2024-06-28T14:20:28Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android.mov

Android: mWeb Chrome

iOS: Native

ios.mov

iOS: mWeb Safari

mSafari.mov

MacOS: Chrome / Safari

chrome.mov

chrome.another.mov

MacOS: Desktop

desk.mov

hungvu193

LGTM 🚀

yuwenmemon · 2024-06-28T18:11:53Z

src/CONST.ts

                SAGE_INTACCT_SYNC_IMPORT_EMPLOYEES: 'intacctImportEmployees',
+                SAGE_INTACCT_SYNC_IMPORT_DIMENSIONS: 'intacctImportDimensions',


NAB: Why move this it was in alphabetical order already 🤔

OSBotify · 2024-06-28T18:41:54Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-03T20:00:33Z

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.0.4-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-04T22:13:00Z

🚀 Cherry-picked to staging by https://github.com/tgolen in version: 9.0.4-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-10T10:56:17Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-15T20:18:53Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ishpaul777 · 2024-08-10T17:50:08Z

src/pages/workspace/accounting/intacct/ExistingConnectionsPage.tsx

+        const lastSuccessfulSyncDate = policy.connections?.intacct.lastSync?.successfulDate;
+        const date = lastSuccessfulSyncDate ? datetimeToRelative(lastSuccessfulSyncDate) : undefined;
+        return {
+            title: policy.name,


There was a regression #45848, we have to add avatarID as policy.id so has same avatar color as the workspace.

eh2077 · 2024-08-19T15:19:17Z

src/pages/workspace/accounting/PolicyAccountingPage.tsx

@@ -143,8 +159,7 @@ function PolicyAccountingPage({policy, connectionSyncProgress}: PolicyAccounting
    const accountingIntegrations = Object.values(CONST.POLICY.CONNECTIONS.NAME).filter((name) => !(name === CONST.POLICY.CONNECTIONS.NAME.NETSUITE && !canUseNetSuiteIntegration));
    const connectedIntegration = accountingIntegrations.find((integration) => !!policy?.connections?.[integration]) ?? connectionSyncProgress?.connectionName;
    const policyID = policy?.id ?? '-1';
-    const successfulDate = policy?.connections?.quickbooksOnline?.lastSync?.successfulDate;
-    const formattedDate = useMemo(() => (successfulDate ? new Date(successfulDate) : new Date()), [successfulDate]);
+    const successfulDate = getIntegrationLastSuccessfulDate(connectedIntegration ? policy?.connections?.[connectedIntegration] : undefined);


This PR caused a regression here - #45780

We should get the last successful date of the integration. Then, if connectionSyncProgress is the same integration displayed and the state is 'jobDone', get the more recent update time of the two.

SzymczakJ added 11 commits June 12, 2024 15:28

add connect to sage intacct button

75fd912

add intacct prerequisites screen

2baa77a

fix IntacctPrerequisitesPage styling

c223592

add EnterSageIntacctCredentialsPage screen

f17c09f

add ExistingConnectionsPage

78e810d

add spanish translations

9464001

Merge branch 'main' into @szymczak/connect-to-sage-intacct

b3867f7

clean up code

fd12010

fix type errors

b28456e

fix typo

096f9dd

fix error names

f6c0528

war-in reviewed Jun 17, 2024

View reviewed changes

SzymczakJ added 7 commits June 17, 2024 19:18

fix PR comments

dc01b0b

fix types

720e8a4

clean up DateUtils

8f448b1

fix type errors

530a407

fix translations

93b5aa0

fix translations

277f574

fix eslint

722ceed

war-in reviewed Jun 18, 2024

View reviewed changes

SzymczakJ marked this pull request as ready for review June 18, 2024 13:21

SzymczakJ requested review from a team as code owners June 18, 2024 13:21

melvin-bot bot requested review from hungvu193 and removed request for a team June 18, 2024 13:21

war-in approved these changes Jun 18, 2024

View reviewed changes

hungvu193 reviewed Jun 18, 2024

View reviewed changes

fix PR comments

aa1ed19

SzymczakJ added 2 commits June 27, 2024 14:45

fix not showing avatars

6349f17

add displayNames to match standard

ed9e7f8

This comment was marked as resolved.

Sign in to view

SzymczakJ added 4 commits June 28, 2024 09:26

merge main

4d05367

clean up sage intacct modules

984447a

fix lint

3c0f992

add key prop to stop console errors

173fcd8

SzymczakJ added 2 commits June 28, 2024 14:22

fix navigation loop

510c45e

Merge branch 'main' into @szymczak/connect-to-sage-intacct

a84a85d

hungvu193 approved these changes Jun 28, 2024

View reviewed changes

melvin-bot bot requested a review from yuwenmemon June 28, 2024 14:20

yuwenmemon approved these changes Jun 28, 2024

View reviewed changes

yuwenmemon merged commit 1f9b4e0 into Expensify:main Jun 28, 2024
16 checks passed

yuwenmemon mentioned this pull request Jun 28, 2024

Hide Sage Intacct behind NetSuite beta for now #44648

Merged

48 tasks

github-actions bot mentioned this pull request Jul 3, 2024

Deploy Checklist: New Expensify 2024-07-03 #44782

Closed

izarutskaya mentioned this pull request Jul 4, 2024

Sage Intacct - Back button on workspace editor returns to Accounting page again #44813

Closed

6 tasks

melvin-bot bot mentioned this pull request Jul 10, 2024

[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [#Wave-Control - Add Sage Intacct] Add the Connection option and Connection button in NewDot #43532

Closed

ishpaul777 reviewed Aug 10, 2024

View reviewed changes

ishpaul777 mentioned this pull request Aug 10, 2024

[HOLD for payment 2024-08-05] [$250] Sage Intacct - Workspace in "Reuse existing connection" list has different workspace avatar color #45848

Closed

6 tasks

eh2077 reviewed Aug 19, 2024

View reviewed changes

eh2077 mentioned this pull request Aug 19, 2024

[HOLD for payment 2024-08-14] [$250] Accounting - Last synced time doesn't reflect the correct time #45780

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Connect to sage intacct #43661

Connect to sage intacct #43661

SzymczakJ commented Jun 13, 2024 •

edited

Loading

SzymczakJ commented Jun 17, 2024

war-in Jun 17, 2024

war-in Jun 18, 2024

war-in Jun 18, 2024

war-in Jun 18, 2024

SzymczakJ Jun 18, 2024

war-in Jun 18, 2024

SzymczakJ Jun 18, 2024 •

edited

Loading

melvin-bot bot commented Jun 18, 2024

war-in left a comment

hungvu193 Jun 18, 2024

SzymczakJ Jun 18, 2024

hungvu193 Jun 19, 2024

SzymczakJ Jun 19, 2024

hungvu193 commented Jun 28, 2024 •

edited

Loading

This comment was marked as resolved.

hungvu193 commented Jun 28, 2024 •

edited

Loading

SzymczakJ commented Jun 28, 2024

hungvu193 commented Jun 28, 2024

hungvu193 left a comment

yuwenmemon Jun 28, 2024

OSBotify commented Jun 28, 2024

OSBotify commented Jul 3, 2024

OSBotify commented Jul 4, 2024

OSBotify commented Jul 10, 2024

OSBotify commented Jul 15, 2024

ishpaul777 Aug 10, 2024

eh2077 Aug 19, 2024

		SAGE_INTACCT_SYNC_IMPORT_EMPLOYEES: 'intacctImportEmployees',
		SAGE_INTACCT_SYNC_IMPORT_DIMENSIONS: 'intacctImportDimensions',

Connect to sage intacct #43661

Connect to sage intacct #43661

Conversation

SzymczakJ commented Jun 13, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

SzymczakJ commented Jun 17, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SzymczakJ Jun 18, 2024 • edited Loading

Choose a reason for hiding this comment

melvin-bot bot commented Jun 18, 2024

war-in left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hungvu193 commented Jun 28, 2024 • edited Loading

This comment was marked as resolved.

hungvu193 commented Jun 28, 2024 • edited Loading

SzymczakJ commented Jun 28, 2024

hungvu193 commented Jun 28, 2024

Reviewer Checklist

Screenshots/Videos

hungvu193 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OSBotify commented Jun 28, 2024

OSBotify commented Jul 3, 2024

OSBotify commented Jul 4, 2024

OSBotify commented Jul 10, 2024

OSBotify commented Jul 15, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SzymczakJ commented Jun 13, 2024 •

edited

Loading

SzymczakJ Jun 18, 2024 •

edited

Loading

hungvu193 commented Jun 28, 2024 •

edited

Loading

hungvu193 commented Jun 28, 2024 •

edited

Loading